-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22027 Add Temporal related Calendar API #2274
Conversation
70f6062
to
08731ad
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
08731ad
to
8adf9ba
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
8adf9ba
to
2e9ed9a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
2e9ed9a
to
5cec64c
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
sorry, please hold the review, there is still some bug in this PR |
5cec64c
to
e6d9454
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
e6d9454
to
3137c97
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
3137c97
to
c76bff7
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
c76bff7
to
559b9eb
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
559b9eb
to
6d55b66
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
6d55b66
to
e6429e7
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
e6429e7
to
1933758
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
1933758
to
6dcae05
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
6dcae05
to
e6e6773
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I have no idea why "adaboost-icu4j-build-and-test (pull_request)" is broken here since I didn't touch any Java code in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got about a third of the way through this before I realized that I'm not really qualified to review this code, but for what it's worth, the structural stuff all makes sense to me and I have no reason to doubt how you're doing the calendrical calculations (although I'd really like another pair of eyes on all this stuff). I did have a few small questions about the documentation, but nothing too earth-shattering.
I didn't actually review the unit tests in detail-- I got lost very quickly. I apologize for this.
Please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM.
API proposal https://docs.google.com/document/d/1UYriEzzExiLhi2RD3zjTsI5UQHv1dXaFqrct7yXNdCA/edit#heading=h.x9obor85vpx9 Design Doc https://docs.google.com/document/d/15ViyC9s0k3VEDwBmAkKxxz4IadZ6QrAIoETkdkF0cVA/ ICU-22027 Adjust API to remove the mention of M00L for now.
f044315
to
48de546
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Rich- I squeshed PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM.
Peter, if you have other concerns, please file bug against me and I will fix it in subsequent PR. Thanks |
Fix broken test mistakenly landed in unicode-org#2274 Some important steps were missed in the last landing.
Fix broken test mistakenly landed in #2274 Some important steps were missed in the last landing.
Checklist
API proposal
https://docs.google.com/document/d/1UYriEzzExiLhi2RD3zjTsI5UQHv1dXaFqrct7yXNdCA/edit#heading=h.x9obor85vpx9
Design Doc https://docs.google.com/document/d/15ViyC9s0k3VEDwBmAkKxxz4IadZ6QrAIoETkdkF0cVA/edit#