ICU-21710 Additional clean up after removing BOYER_MOORE code from usearch.cpp #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
markusicu
previously approved these changes
Aug 27, 2021
…earch.cpp Changes: - We can completely remove the shift tables and related fields from data structs. - Creation of UStringSearch objects should be faster now, as it doesn't waste time computing the unused shift tables. - The sizeof(UStringSearch) is decreased from 5240 to 3192, so this should help to reduce memory for applications that create many string search objects. Note regarding the comments on initialize(). It actually does not set illegal argument error if pattern is all ignoreables. Added a test case for it.
jefgen
force-pushed
the
user/jefgen/usearch-clean-up
branch
from
b05f3b7 to
4e685ad
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to PR #1800 (which removed BOYER_MOORE dead code from usearch.cpp).
This PR contains additional clean-up.
Thanks to Andy for pointing out on the other PR that
initializeandsetShiftTablewere still setting up Boyer-Moore related data. It turns out that we can we can completely remove the shift tables and related fields from the data structs, as well as remove thesetShiftTablemethod.The creation of
UStringSearchobjects should be slightly faster now, as we no longer waste time computing the unused shift tables (which hashed the pattern collation elements).The
sizeof(UStringSearch)is decreased from 5240 bytes to 3192 bytes (on x64), so this should help to reduce memory for applications that create many string search objects.Also added a test case for a pattern with only ignoreable CEs. The comments on
initializesaid: "If pattern has no non-ignorable ce, we return a illegal argument error". However, it actually does not set illegal argument error.Checklist