CLDR-17566 fix to GitHub Pages build #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
previously approved these changes
Apr 29, 2024
srl295
force-pushed
the
cldr-17566/fix-docgen
branch
from
30c3a70 to
12611a8
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- use correct build command to include subdirectories - exclude and treat ldml specially - skip node_modules and other cruft in build - fix GitHub API token and workflow permissions issue - use a more modern GitHub pages upload process
srl295
force-pushed
the
cldr-17566/fix-docgen
branch
from
12611a8 to
1f7a7e6
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
|
@macchiati Please re-review. works now |
macchiati
approved these changes
Apr 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17566
Looking at #3650 I realized that some subdirectories were not getting build properly. This fixes the build to use
github-pages buildinstead of rawjekyll. FYI @lianghaiTo review, see: (note srl URL)
These are broken in current main, for example https://unicode-org.github.io/cldr/dev/generate-emoji-paths.html and https://unicode-org.github.io/cldr/site/downloads/cldr-45.html
arewere dead links.edit these links are fixed by this PR.
ALLOW_MANY_COMMITS=true