CLDR-17561 Utility for visiting DtdData elements #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft; will need some dtd fixes and/or exceptions. |
btangmu
approved these changes
Apr 23, 2024
| "", "references", // | ||
| "", "cp", // | ||
| "version", "", // | ||
| // "ruleset", "type", // |
There was a problem hiding this comment.
Commented-out code and empty comments are messy to begin with, and messier due to deep indentation and formatting that breaks up some but not all pairs. Ideally the parameters for add() might be moved to a named constant defined outside the method call, less indented, maybe as an array of Map.Entry objects for element/attribute pairs...
The semantics of these elements and attributes are still mostly beyond my understanding. I sometimes wonder whether defining constants for such strings, maybe as members of enums, and referencing them as such rather than as string literals could be helpful for understanding the code and maybe for catching typos...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17561
ALLOW_MANY_COMMITS=true