Fix: Random Delimiter in CSV Parser #545
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
test testDelimiterDiscovery randomly failed due to the output is not "1", "2;2", "3;3", "4;a" but "1,2", "2,3", "3,4", "a".
Reason
In the CSV Parser, we use several rules to determine the delimiter. like if the optional delimiter exists in all rows or how many times the delimiter exists in the current row. If there are two optional delimiters met all rules with the same weight, they will remain in the method "pickDelimiter" in "CsvFormatDetector.java". Since we use a HashSet to store all delimiters, one delimiter will be randomly output.
Change
Use LinkedHashSet instead of HashSet so the out delimiter will be the same in different runs.