Switch to postcss + css variables #38
Conversation
|
Oh, one other thing, I fixed a bug in post-css cli, so landing this will depend on that: postcss/postcss-cli#286 |
|
The other ope questions would be:
|
Also simplify site and build steps and some general cleanup.
|
Also, I should still go through the docs and website to make sure all that info is up to date. |
|
Hey @bcomnes, I'm out on vacation for a few more days so I won't be able to give this a full review until next week. However at a glance, this looks like a lot of different major breaking changes! I get the sense that in addition to switching to postcss, there are also changes in where the distribution files are kept, how source files are organized, possibly changes in design, a new dark mode that I'm not sure how to review, major bumps for almost all dependencies, major readme file changes, changes to CI setup, and probably other stuff I'm not yet aware of? In summary this is ... unreviewable? It would be a lot easier to review if this were broken up into PRs with separate concerns. I can't reasonably say this is OK to merge when I have no idea how much has changed and what this will break. |
|
Yeah sorry, the work resulted from wanting to iterate on what was here in a somewhat breaking way. I originally was intending to create a personal fork with these changes, but I figured it would be worth offering them up as an upstream change before I settle for that. Basically it boils down to these changes: Switch to using css variables instead of sass variablesCSS variables make it easier to support dark mode themes and generally can assist in simplified theming when it comes to colors and such. It also makes it easier to support the serif variant. All you need it to override a var instead of use a different css file. Support dark mode by defaultStill a WIP but it would be a nice addition I think to support this by default. Move the preprocessor to postcssProvides a lot of the same features, with a syntax closer to theoretical future css. Personal preference, not sure where you are on this one. Reorg the websiteThis work came out of the original motivation (soft personal fork to achieve the above goals) and was finished before I decided to offer up the changes to you in this repo. How to reconcile. Are you interested in any of the above changes landing here? I'm guessing maybe the css-var support and dark mode? The post-css and website reorg were mainly the path I took to try those out and are the bigger change. It could be possible to separate these in various ways. In terms of what would break. The release would be a breaking change 2.0. The website would be updated, and people consuming from unpkg without a major version number might break. Also old browser that don't support css vars would break. The other alternative is to do a soft fork, maybe like @bret/style.css or something. |
|
Sorry @bcomnes, I don't mean to be keep blocking your PR, I've just had no time at all in the last month for open source. 😭 If you want to just keep going with it feel free to do the soft fork, I'll try to pull it down and do a real review soon. 🤞 |
|
No problem at all 🤗 happy to converge in the future if it makes sense |
|
Sorry to keep this open for ages. Moving it into its own repo. |
Also simplify site and build steps and some general cleanup.
I was experimenting with switching this over to post-css for a while now, and here is the result of that work. The main advantage is that style.css is based on css variables, so doing things like dark mode are a bit easier, since you can just switch out pointer vars and things like that.
wdyt @ungoldman ?