-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enterprise github auth #74
Conversation
@ungoldman Fixed up GitHub enterprise auth and url detection and tested it on our GitHub enterprise server. Everything works with these changes! Could you review whenever you get a chance? Would be awesome to get this in |
Looks good at first glance, will try to test it out in the next 24 hours! |
Awesome, thanks! Also, thanks for gh-release in the first place, it's an awesome tool that really helps to streamline our workflow |
@ungoldman Hate to bug you about this, but any chance you might be able to take another look at this PR sometime today or tomorrow? Also wondering if you guys are looking for help maintaining this project, or with any of the other issues that are open on it. I was considering tackling #49 when I get some free time as that would be a really nice enhancement to gh-release 😄 Thanks! |
LGTM 👍 Also yes, I would be happy to welcome another maintainer and please do feel free to tackle any issues! All we ask is you read the collaborator guidelines: https://github.com/hypermodules/gh-release/blob/master/CONTRIBUTING.md#rules Generally any change should be in a PR, and should be approved by a maintainer who didn't open the PR before being merged. Also this module is used by a fair number of projects so the main thing is to try to be careful not to introduce breaking changes lightly, and to try to be backwards compatible with current functionality whenever possible. Thank you @tjaneczko! (invite sent) |
📦 |
fwiw, i tested this branch in GitHub enterprise and everything was 👍 |
Thanks @jgravois 🙏 |
Awesome, thanks for reviewing @ungoldman and thanks for testing @jgravois !! Accepted the invite, the collaborator guidelines all look kosher and I'm happy to help out with contributing and maintaining this project! |
We need to pass the authUrl to ghauth when working with GitHub enterprise, otherwise it'll try to use a token from github.com