Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional audiences #35

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Allow additional audiences #35

merged 4 commits into from
Jul 17, 2023

Conversation

MichaelChovanakDatavant
Copy link
Contributor

@MichaelChovanakDatavant MichaelChovanakDatavant commented Jul 13, 2023

I recently fixed an authentication issue by adding https://github.com/<organization> as an allowed audience in the github IAM trust relation, but I could not persist the change in terraform using this module.

This change adds the ability to optionally specify additional_audiences = ["<another_audience>", ...], which when omitted retains the default allowed audience of 'sts.amazonaws.com'

@unfunco
Copy link
Owner

unfunco commented Jul 17, 2023

Hey @MichaelChovanakDatavant – thank you for this, I'm happy for this feature to go in but can we rename the variable to additional_audiences so that it's consistent with the additional_thumbprints variable name, and can we also always include sts.amazonaws.com as an audience instead of putting it in the variable default? We do the same thing with thumbprints, we allow additional ones to be added but we don't allow the defaults to be overridden.

@MichaelChovanakDatavant
Copy link
Contributor Author

@unfunco Thanks for the feedback! I've changed it to additional_audiences.

@unfunco
Copy link
Owner

unfunco commented Jul 17, 2023

Excellent. Thanks! I'll get a new release out shortly!

@unfunco unfunco merged commit d5f4644 into unfunco:main Jul 17, 2023
@MichaelChovanakDatavant MichaelChovanakDatavant deleted the allow-additional-audiences branch August 3, 2023 22:35
@github-actions github-actions bot mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants