Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing on tags should be map not object #3

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix: typing on tags should be map not object #3

merged 1 commit into from
Mar 2, 2022

Conversation

henworth
Copy link
Contributor

@henworth henworth commented Mar 2, 2022

This changes the typing declaration on var.tags to ensure tags can be properly passed in. When defined as object({}) the input tag contents seem to be ignored as is evident by this truncated plan:

  # aws_iam_openid_connect_provider.github[0] will be created
  + resource "aws_iam_openid_connect_provider" "github" {
      + arn             = (known after apply)
      + client_id_list  = [
          + "https://github.com/REDACTED",
          + "sts.amazonaws.com",
        ]
      + id              = (known after apply)
      + tags_all        = (known after apply)
      + thumbprint_list = [
          + "6938fd4d98bab03faadb97b34396831e3780aea1",
        ]
      + url             = "https://token.actions.githubusercontent.com"
    }

When changed there as in this PR, there is a tag attribute with the expected contents.

@unfunco unfunco merged commit 3f5b6fe into unfunco:main Mar 2, 2022
@unfunco
Copy link
Owner

unfunco commented Mar 2, 2022

Thank you for this, I noticed the tags were missing a week or two ago but hadn't looked into it yet, I'll sort a couple of other bits out and will release a new version this evening.

@henworth henworth deleted the patch-1 branch March 2, 2022 18:08
@unfunco
Copy link
Owner

unfunco commented Mar 2, 2022

I've tagged v0.4.1 which includes your fix, thanks again!

henworth added a commit to henworth/terraform-aws-oidc-github that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants