Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS and Windows builds in Github Actions #6649

Merged
merged 12 commits into from
Jan 20, 2020
Merged

Fix macOS and Windows builds in Github Actions #6649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b597e67
rebuilt package-lock and fixed security warnings
da1nerd Jan 16, 2020
c551791
split macOS building and bundling into two steps
da1nerd Jan 16, 2020
3e1f6bf
print node version before running jobs
da1nerd Jan 16, 2020
aebb07e
run platform builds without tests for easier debugging
da1nerd Jan 16, 2020
e0b3864
set node version in jobs
da1nerd Jan 16, 2020
56674be
run mac builds on the linux environment until build bugs can be resolved
da1nerd Jan 16, 2020
62c8595
update checkout action for windows
da1nerd Jan 16, 2020
a0a3324
re-enable macos environment
da1nerd Jan 16, 2020
5e9a6f7
switch to using v2 checkout action for all actions
da1nerd Jan 16, 2020
7bfafbb
revert checkout code for linux environment
da1nerd Jan 16, 2020
75ae321
only update resources when environment variable is set
da1nerd Jan 16, 2020
8abf69c
install specific version of node on windows and mac environments
da1nerd Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 73 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ jobs:
node --version
npm --version

# - uses: actions/checkout@v2
# - name: Checkout submodules
# shell: bash
# run: |
# auth_header="$(git config --local --get http.https://github.com/.extraheader)"
# git submodule sync --recursive
# git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1

- name: Checkout codebase
uses: actions/checkout@v1
with:
Expand All @@ -46,7 +54,7 @@ jobs:

build-linux:
name: Build Linux
needs: test
# needs: test
runs-on: ubuntu-latest
container: neutrinog/concourse-tasks:latest
env:
Expand All @@ -56,6 +64,19 @@ jobs:
CI: true

steps:
- name: Node version
run: |
node --version
npm --version

# - uses: actions/checkout@v2
# - name: Checkout submodules
# shell: bash
# run: |
# auth_header="$(git config --local --get http.https://github.com/.extraheader)"
# git submodule sync --recursive
# git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1

- name: Checkout codebase
uses: actions/checkout@v1
with:
Expand All @@ -79,9 +100,11 @@ jobs:
run: npm ci

- name: Download latest language names
if: env.UPDATE_RESOURCES
run: curl https://td.unfoldingword.org/exports/langnames.json > src/assets/langnames.json

- name: Update resources
if: env.UPDATE_RESOURCES
run: npm run update-resources

- name: build linux
Expand All @@ -99,7 +122,7 @@ jobs:

build-windows:
name: Build Windows
needs: test
# needs: test
runs-on: windows-latest
env:
TC_HELP_DESK_TOKEN: ${{ secrets.TC_HELP_DESK_TOKEN }}
Expand All @@ -108,10 +131,27 @@ jobs:
CI: true

steps:
- name: Checkout codebase
uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
submodules: recursive
node-version: '8.16.1'

- name: Node version
run: |
node --version
npm --version

- uses: actions/checkout@v2
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1

# - name: Checkout codebase
# uses: actions/checkout@v1
# with:
# submodules: recursive

- name: Read version and commit sha
run:
Expand All @@ -129,9 +169,11 @@ jobs:
run: npm ci

- name: Download latest language names
if: env.UPDATE_RESOURCES
run: curl https://td.unfoldingword.org/exports/langnames.json > src/assets/langnames.json

- name: Update resources
if: env.UPDATE_RESOURCES
run: npm run update-resources

- name: build windows
Expand Down Expand Up @@ -175,7 +217,7 @@ jobs:

build-macos:
name: Build macOS
needs: test
# needs: test
runs-on: macos-latest
env:
TC_HELP_DESK_TOKEN: ${{ secrets.TC_HELP_DESK_TOKEN }}
Expand All @@ -184,10 +226,27 @@ jobs:
CI: true

steps:
- name: Checkout codebase
uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
submodules: recursive
node-version: '8.16.1'

- name: Node version
run: |
node --version
npm --version

- uses: actions/checkout@v2
- name: Checkout submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1

# - name: Checkout codebase
# uses: actions/checkout@v1
# with:
# submodules: recursive

- name: Read version and commit sha
run: |
Expand All @@ -207,17 +266,21 @@ jobs:
run: npm ci

- name: Download latest language names
if: env.UPDATE_RESOURCES
run: curl https://td.unfoldingword.org/exports/langnames.json > src/assets/langnames.json

- name: Update resources
if: env.UPDATE_RESOURCES
run: npm run update-resources

- name: build macOS
id: build
run: |
echo "Building $APP_VERSION-$HASH"
./node_modules/.bin/gulp build --macos
./node_modules/.bin/gulp release-macos --out=../artifacts/$ARTIFACT_NAME

- name: bundle macOS
run: ./node_modules/.bin/gulp release-macos --out=../artifacts/$ARTIFACT_NAME

- uses: actions/upload-artifact@v1
name: Upload artifacts
Expand Down
Loading