Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite not fully working in Electronite #6879

Closed
birchamp opened this issue Apr 29, 2020 · 15 comments
Closed

Graphite not fully working in Electronite #6879

birchamp opened this issue Apr 29, 2020 · 15 comments

Comments

@birchamp
Copy link
Contributor

birchamp commented Apr 29, 2020

The simple grahite test works but the complex scripts don't.
See: #6723 (comment)

@birchamp
Copy link
Contributor Author

birchamp commented Apr 29, 2020

DoD: SIL graphite test page renders properly with Electronite.

@BincyJ BincyJ added this to the tC Sprint#94 milestone Apr 29, 2020
@da1nerd
Copy link
Contributor

da1nerd commented Apr 30, 2020

Here's another example that works. #6723 (comment)

The Padauk font is not rendering correctly.

@da1nerd
Copy link
Contributor

da1nerd commented Apr 30, 2020

@jag3773 do you remember if we were able to render the Padauk font correctly when we first created Electronite? I though we had, but now I'm wondering if we only tested the Awami Nastaliq font.

@da1nerd
Copy link
Contributor

da1nerd commented Apr 30, 2020

Link to the graphite repo https://github.com/silnrsi/graphite

@da1nerd
Copy link
Contributor

da1nerd commented Apr 30, 2020

I reached out for some help on the graphite repo silnrsi/graphite#63.

NOTE: I confirmed graphite is not fully functional on linux or windows. I'm guessing others tried out macOS as well.

@da1nerd
Copy link
Contributor

da1nerd commented Apr 30, 2020

Are we missing something in /third_party/graphite/BUILD.gn?

@da1nerd
Copy link
Contributor

da1nerd commented May 1, 2020

I discovered we had been using a broken version of graphite silnrsi/graphite@4fb12b3.

Rebuilding with a patched versions now. Hopefully that solve the problem.

Update: It did not fix the problem.

@da1nerd
Copy link
Contributor

da1nerd commented May 6, 2020

Figured it out thanks to Martin.

The padauk font is loaded using the following css on the demo page.

.padauk_ttf {
  font-family: PadaukT, sans-serif;     
  font-size: 150%;
  -moz-font-feature-settings: "wtri=1";
  -moz-font-feature-settings: "wtri" 1;
}

Since electronite is chromium, the -moz tags don't work.
inserting font-feature-settings: "wtri" 1; fixed the display of the Padauk font.

@da1nerd
Copy link
Contributor

da1nerd commented May 8, 2020

Confirmed https://github.com/mannycolon/electronite-poc-app works on:

  • Pop! OS 64bit (linux)
  • Windows 10 64bit (virtual machine)
  • macOS High Sierra 64bit
  • Windows 32

@mannycolon
Copy link
Contributor

Can confirm that after making the suggested CSS tweak the Padauk rendered correctly in my machine. However, the Arabic (Awami Nastaliq font) still isn't working for me.

Padauk Font

Screen Shot 2020-05-08 at 11 15 34 AM

Screen Shot 2020-05-08 at 11 28 12 AM

Awami Nastaliq Font

Screen Shot 2020-05-08 at 11 15 37 AM

@da1nerd
Copy link
Contributor

da1nerd commented May 13, 2020

For posterity, we've confirmed that electronite can now pass all the tests on the SIL test page.

@cckozie
Copy link

cckozie commented May 13, 2020

electronite-poc-app
As Manny's comment referenced above, the Paduak font is being displayed correctly in the POC. The Awami Nastaliq Font is not. So it seems to me that this issue is not ready for QA.
Am I wrong or missing something?
image

@da1nerd
Copy link
Contributor

da1nerd commented May 14, 2020

@cckozie that is incorrect. The awami font is working correctly. The text is simply not wrapping at the same points because the browser is not the same width as when the SIL team took their screenshot.
Also, the line height is different. Neither of those are related to font rendering.

@birchamp
Copy link
Contributor Author

@cckozie Please connect with @neutrinog to reproduce the steps to get it working.

On my machine I'm seeing what Joel is seeing Graphite-POC-Awami.png

@cckozie
Copy link

cckozie commented May 18, 2020

Taking Birch's word that this is working as is should be. If problems still exist they will be written up in tC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants