-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite not fully working in Electronite #6879
Comments
DoD: SIL graphite test page renders properly with Electronite. |
Here's another example that works. #6723 (comment) The Padauk font is not rendering correctly. |
@jag3773 do you remember if we were able to render the Padauk font correctly when we first created Electronite? I though we had, but now I'm wondering if we only tested the Awami Nastaliq font. |
Link to the graphite repo https://github.com/silnrsi/graphite |
I reached out for some help on the graphite repo silnrsi/graphite#63.
|
Are we missing something in |
I discovered we had been using a broken version of graphite silnrsi/graphite@4fb12b3. Rebuilding with a patched versions now. Hopefully that solve the problem.
|
Figured it out thanks to Martin. The padauk font is loaded using the following css on the demo page.
Since electronite is chromium, the |
Confirmed https://github.com/mannycolon/electronite-poc-app works on:
|
For posterity, we've confirmed that electronite can now pass all the tests on the SIL test page. |
@cckozie that is incorrect. The awami font is working correctly. The text is simply not wrapping at the same points because the browser is not the same width as when the SIL team took their screenshot. |
@cckozie Please connect with @neutrinog to reproduce the steps to get it working. |
Taking Birch's word that this is working as is should be. If problems still exist they will be written up in tC. |
The simple grahite test works but the complex scripts don't.
See: #6723 (comment)
The text was updated successfully, but these errors were encountered: