Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate rendering of complex scripts #6788

Closed
birchamp opened this issue Mar 25, 2020 · 15 comments
Closed

Validate rendering of complex scripts #6788

birchamp opened this issue Mar 25, 2020 · 15 comments

Comments

@birchamp
Copy link
Contributor

birchamp commented Mar 25, 2020

Burmese and the MENA region have been identified as needing complex script support in tC.
For reference see #6879 and SIL's Graphite demo page

For Burmese/Myanmar:

For MENA/Arabic/Urdu
Awami Nastaliq

Scheherazade

@birchamp
Copy link
Contributor Author

birchamp commented Apr 7, 2020

@jag3773 do you have contacts that can verify complex script rendering?

@jag3773
Copy link
Contributor

jag3773 commented Apr 13, 2020

First test should be run against https://scripts.sil.org/cms/scripts/page.php?site_id=projects&item_id=graphite_fontdemo but If that passes I can send a screenshot for expert review.

@BincyJ
Copy link

BincyJ commented May 11, 2020

@birchamp to provide text for Burmese and Arabic to validate. We also need a way to confirm the rendering in tC. May need a tester / confirmation from a reader.
Need confirmation on the scope of languages needed for Complex Script support release.

@birchamp
Copy link
Contributor Author

This issue is used for validating the work done for #6935

@mannycolon mannycolon self-assigned this May 25, 2020
@cckozie
Copy link

cckozie commented Jun 1, 2020

3.0.0 (c8646fa)
Alex verified that the rendering in tC and Paratext are both correct. The differences are caused by a difference in fonts.
Comparing this screenshot from 1:2 in the https://git.door43.org/birch/ar_vdb_tit_book project to a screenshot taken from Paratext created from a USFM export of that project.
(Paratext on top, tC on bottom of screenshots)
Paratext uses Charis SIL as the default font for the language, and Scheherazade is not in their dropdown font list.
There are some subtle and some more obvious differences. Are these acceptable? Are the differences caused by different fonts?
image

@cckozie
Copy link

cckozie commented Jun 1, 2020

3.0.0 (c8646fa)
The (my) font appears to be correctly rendered wherever it is displayed, but the font size is noticeably smaller in the edit pane of the expanded scripture pane (and from the tool bar in wA) than in the other panes where it is dispayed. (This 'problem' should be eliminated by the font sizing issue)
image

@cckozie
Copy link

cckozie commented Jun 2, 2020

3.0.0 (c8646fa)
https://git.door43.org/birch/ar_vdb_tit_book
57-TIT_myanmar_judson_1835_utf8.usfm.txt.zip

ISSUE A: Fixed in 3.0.0 (a03e2cc)
We are using a different font than the one selected when displaying the book name in the check pane of tN and tW, and in the verse edit pane for the scripture pane.
Before taking this screenshot I copied the book name into the beginning of the verse 1:1 text. The text in the two outlined boxes is the same but appears differently. This is with the Scheherazade font selected:
image

This is with the Awami Nastaliq font selected:
image
image

ISSUE B: Fixed in 3.0.0 (a03e2cc)
The default font size is too large and the line spacing too small for the Awami Nastaliq font.

ISSUE C: (Questions)
There appears to be a problem with the tokenizer in Burmese, and maybe with word breaks too. Where we break words to line wrap seems to be almost arbitrary. Is that acceptable in Burmese?
image
image

image

@birchamp
Copy link
Contributor Author

birchamp commented Jun 3, 2020

Issue C is good enough for now until we have a better Burmese text.

@cckozie
Copy link

cckozie commented Jun 4, 2020

@mannycolon - I found a few other places with problems. One where the default font is being used; when hovering over a word in the word bank. Some with a sizing problems. Is it OK to leave them here, or would you rather that I create another issue for them (and maybe others that I may run across)?
ISSUE D: Cannot test this now since the hover problems has been fixed
image

ISSUE E: Fixed in 3.0.0 (a03e2cc)
image

ISSUE F:
image

@mannycolon
Copy link
Contributor

@cckozie These are good for now, I will include them with the work I'm doing now.

@cckozie
Copy link

cckozie commented Jun 4, 2020

@mannycolon
ISSUE G: Has not been fixed 3.0.0 (a03e2cc)
Found another one. This is from clicking the expand pane icon in the check pane in tN. (It probably would be good to increase the size on this one too if that's just a simple setting)
image

@mannycolon
Copy link
Contributor

mannycolon commented Jun 7, 2020

Verified on cbed56b

@cckozie cckozie self-assigned this Jun 8, 2020
@cckozie
Copy link

cckozie commented Jun 8, 2020

3.0.0 (dad3c32)
ISSUE A: Both problems noted have been fixed except for the problem of the font used for the language abbreviation noted below.

ISSUE B: This problem has been fixed.

ISSUE C: N/A

ISSUE D: Unable to test in this build because the word bank hover-over is not working.

ISSUE E: Has been fixed

ISSUE F: Has been fixed.

ISSUE G: Has been fixed. I'm creating a new issue for the font size problem (#6978)

@cckozie
Copy link

cckozie commented Jun 8, 2020

@mannycolon - I wrote this up here because I am assuming this problem was introduced by the fixes made for this issue. If that is not what cause it, I'll create a new issue for it.
ar_test_rut_book.zip
The font for the word Arabic and abbreviation (AR) has changed. Not fixed in 3.0.0 (a03e2cc) @birchamp - Are you OK with this? Created issue #7025 for this if we want to change it.
The color of the text description (target, orignal, gateway, etc.) has changed. I think it now may also be bolded. Fixed in 3.0.0 (a03e2cc)
This is from 3.0.0 (dad3c32)
image

This is from 3.0.0 (c8646fa) and previous:
image

@cckozie cckozie removed their assignment Jun 8, 2020
@mannycolon
Copy link
Contributor

mannycolon commented Jun 29, 2020

Verified on a03e2cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants