Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly reported volume when using .5 as volume step #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

henrikwidlund
Copy link
Contributor

Fixes the volume displayed on the remote so that it isn't constantly .5 too high

@henrikwidlund henrikwidlund force-pushed the main branch 2 times, most recently from 8be812d to 7230814 Compare December 22, 2024 17:32
@zehnm
Copy link
Contributor

zehnm commented Dec 23, 2024

I have to discuss this first in our team. Technically, 0.5 is rounded up, but I'm not an "audio-head" and don't know what makes more sense in terms of volume level.
I'll also check if there are plans to show 0.5 volume levels in the UI.

If we are going forward, the Python code format has to be fixed so they pass the linter checks: docs/code_guidelines.md

@henrikwidlund
Copy link
Contributor Author

I also have no idea what is more correct, but as a user it is confusing that it says it's louder that it is. Removing the need for rounding in the first place would be ideal, or allowing for specifying how the rounding should work on the remote as a global setting.

Happy holidays!

Fixes the volume displayed on the remote so that it isn't constantly .5 too high
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants