Answer to connect request when already connected (else report as disconnected) #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation will be reported as disconnected
|
This looks like the same fix I've recently applied: 2152b46 The connect / disconnect messages will require a general cleanup and more importantly correctly implemented in the web-configurator. Unfortunately this got mixed up, it was intended to connect & disconnect related devices, but then also got used to determine the state of the integration itself... |
|
Hi Markus @zehnm, indeed this is fixed by your patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the integration is already connected and the remote sends a connect request, the integration will not respond back and will be reported as disconnected. This modification will always report a connect event.
It should be applied to other integrations also that could have the same issue