(feat) add simple commands for Output Monitor 1, Monitor 2, Monitor Auto #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splattner
force-pushed
the
simple_commands_monitor_output
branch
from
2bf5e87 to
b9ace86
Compare
zehnm
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Great, thank you! I need to find an HDMI cable to test my unused HDMI out 2 port :-)
Please fix the linting errors, then I'll merge it and include it in the next release, scheduled for tomorrow.
You can leave the pylint intg-denonavr/media_player.py:93:4: R0915: Too many statements (51/50) (too-many-statements) issue, or add an ignore tag if you like.
The existing if-then-else monster just got too big. I'll replace it with the string case statement.
|
I'll check those. My python dev setup was not really ready/available so I did not lint or anything else... 🙈 sry, but I'll fix asap ;) |
splattner
force-pushed
the
simple_commands_monitor_output
branch
2 times, most recently
from
a578e68 to
d25846a
Compare
splattner
force-pushed
the
simple_commands_monitor_output
branch
from
d25846a to
5297f9e
Compare
|
all fixed and I added a pylint disable for R0915. But I agree, this part should probably be solved a bit nicer |
zehnm
approved these changes
Jun 13, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #37