-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a configurable volume step (in setup flow) and improved refresh of volume #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you! Volume step configurability is a great addition.
I'll need at least another day to test the new volume handling.
The volume step configuration can be defined as a number and limited to the valid range. This simplifies the UI handling and is less error prone.
I don't see a reason to allow larger volume steps than 10 dB, or is there a specific use-case for that?
Hi Markus, I just committed the changes |
Hi, now I remember why I used text field instead of numbers : it won't support decimal numbers. |
The issue is only the
|
…ing fix on API side
Okay I reverted changes and applied step to 1. I didn't understand that the problem was located only on one of the fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Hi,
I have added a configurable volume step in setup flow (and I added necessary checks on the datamodel which may not include this new field).
Also I added a call to async refresh when sending volume up & down commands to have a more precise volume update instead of referring to updated local variable. This avoids "glitches" when the volume is updated locally while an async update (every 10s) occur.