Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional commands (telnet and http protocols) : DPAD and menus #36

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

albaintor
Copy link
Contributor

This is a separate PR for just the additional commands. The other PR will contain only the multi instances part
Related to #33

@zehnm
Copy link
Contributor

zehnm commented Mar 17, 2024

Great! And thank you for also opening a PR in the denonavr library 👍
I'll check it later today when I'm back home.

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with AVR-X2700H and the new functions work 👍

Please fix the cosmetic issues, then I'll merge it.

requirements.txt Outdated Show resolved Hide resolved
intg-denonavr/media_player.py Outdated Show resolved Hide resolved
intg-denonavr/avr.py Outdated Show resolved Hide resolved
intg-denonavr/avr.py Outdated Show resolved Hide resolved
intg-denonavr/avr.py Outdated Show resolved Hide resolved
intg-denonavr/avr.py Outdated Show resolved Hide resolved
@albaintor
Copy link
Contributor Author

All modifications applied, please check for merge

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the changed files in .idea it's ok.

.idea/integration-denonavr.iml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this once merged. Python 3.11 is required to embedd it in the R2 firmware.

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement! I'll create a new release and include it in the next firmware release.

@zehnm zehnm merged commit e5e6599 into unfoldedcircle:main Mar 18, 2024
1 check passed
@albaintor albaintor deleted the additional_commands branch March 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants