-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support multiple instances of Denon AVR #35
base: main
Are you sure you want to change the base?
Conversation
…sted OK on my (real) remote
I think you are using HTTP control for these commands, even if Telnet control was selected in the integration. But thanks for looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enhancing the features!
I'll test the new commands with my Denon AVR this weekend.
Please reach out first when doing bigger changes, see CONTRIBUTING.md. Related issues:
This PR needs to be split into multiple pull request: one for additional commands and another for multi-device support.
I highly suggest to create a dedicated branch for each PR in your repo and avoid using the main branch. Rebasing and PR changes become much easier.
Preferrably, a PR should only contain one feature in one commit.
… fork/PR. Only the multi instance feature in this fork
Hi, About additional commands : I added the 2 modes (telnet and http), whereas only http commands on the previous commit. Tested OK on my setup. However Telnet is supposed to be faster than http commands but it does not feel that way. Maybe http should be preferred In the future I will only use branches |
Hi, |
Thanks for the updated PR! |
Hi, |
Hi, Ralf |
Tested successfully on my remote (not through simulator) :
The embedded library is not up to date so I added the commands directly from the avr.py file.
This new commands work fine on my setup (Denon AVR 4700)