Refactoring for public integration lib 0.1.1 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactored changed API - fixed invalid names - private logging instance
- use a dedicated entity_id with the entity_type as prefix, avr_id as suffix - prepare driver for multiple entities per AVR - more NoneType fixes - more type information
Directly add event listener in _on_subscribe_entities and avoid loop variable in on_update
Use new event listener registration methods. Entity commands are now handled within the entities.
Improve developer UX with setup request & action objects, instead of sending low-level WS messages.
With library fix this closes #2
martonborzak
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mayor refactoring for the newly published integration library on PyPI and our new Docker image for running pyinstaller.
This makes the build much simpler and faster.
Fixed linting issues and improved command handler.