Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.13.3 DMG on Mac only contains the ARM64 version #362

Closed
mORogyrUly opened this issue May 12, 2024 · 2 comments
Closed

0.13.3 DMG on Mac only contains the ARM64 version #362

mORogyrUly opened this issue May 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mORogyrUly
Copy link

mORogyrUly commented May 12, 2024

0.13.3 DMG on Mac only contains the ARM64 version - an Intel compiled version is unfortunately not included

@mORogyrUly mORogyrUly added the enhancement New feature or request label May 12, 2024
@undergroundwires undergroundwires added bug Something isn't working and removed enhancement New feature or request labels May 13, 2024
@undergroundwires undergroundwires changed the title 0.13.3 DMG on Mac only contains the ARM64 version - an Intel compiled version is unfortunately not included 0.13.3 DMG on Mac only contains the ARM64 version May 13, 2024
@undergroundwires
Copy link
Owner

Thank you for @mORogyrUly. It is a bug, it was not intended. The bug is explained here. It was an unexpected side-effects of GitHub updating their runners.

I did a hot-patch now and updated 0.13.3 release to still be the Intel version, so it will be solved if you re-download the DMG file. I will fix this long-term in 0.13.4 with universal package support where both Intel and ARM binaries will be provided.

undergroundwires added a commit that referenced this issue May 16, 2024
This commit introduces a universal binary format in the distributed MDG
files for macOS, improving support for both Apple Silicon (ARM) and
Intel (x64) architectures.

It uses `electron-builder` to package both architectures into a single
executable, ensuring the application can natively on any macOS hardware
without depending on the GitHub runners' architecture. It fixes the
issue related to prior releases that supported only the architecture of
the build environment itself, which is subject to change.

Changes:

- Update DMG distribution to include both ARM64 and x64 architectures.
- Enhance system requirements documentation to reflect support for both
  architectures.
- Modify CI/CD workflows to check desktop runtime errors for both ARM64
  and x64 versions on macOS.

Resolves:

- Issue #348: Initial request for Apple Silicon support.
- Issue #362: Correction of distribution limited to ARM64 in release
  0.13.3.

`electron-builder` support:
- electron-userland/electron-builder#5475
- electron-userland/electron-builder#5689
- electron-userland/electron-builder#5426
undergroundwires added a commit that referenced this issue May 16, 2024
This commit introduces a universal binary format in the distributed MDG
files for macOS, improving support for both Apple Silicon (ARM) and
Intel (x64) architectures.

It uses `electron-builder` to package both architectures into a single
executable, ensuring the application can natively on any macOS hardware
without depending on the GitHub runners' architecture. It fixes the
issue related to prior releases that supported only the architecture of
the build environment itself, which is subject to change.

Changes:

- Update DMG distribution to include both ARM64 and x64 architectures.
- Enhance system requirements documentation to reflect support for both
  architectures.
- Modify CI/CD workflows to check desktop runtime errors for both ARM64
  and x64 versions on macOS.

Resolves:

- Issue #348: Initial request for Apple Silicon support.
- Issue #362: Correction of distribution limited to ARM64 in release
  0.13.3.

`electron-builder` support:
- electron-userland/electron-builder#5475
- electron-userland/electron-builder#5689
- electron-userland/electron-builder#5426
@undergroundwires
Copy link
Owner

0.13.4 is just released 🎉 and it adds native support for both 64-bit and ARM. Thank you for the issue @mORogyrUly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants