Make CI workflows simpler #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmeGak
force-pushed
the
wip/simpler-ci
branch
from
d407df9 to
95a0caa
Compare
ThiefMaster
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't gain anything anymore by having a
setupstep in the workflows. The original idea is that thesetupstep caches the virtualenv generated bypoetry install --no-root, which was common in thelintingandtestingworkflows. They both require to run nowpoetry install.The benefit may haven even been negative before, since our dependencies are not too heavy nor we change them too often. The overhead of having to run an additional step with
actions/checkout@v3andactions/setup-python@v4is likely higher (didn't check) than the any time we may be saving from caching.This PR simplifies the workflows, making them more maintainable, caching instead the entire virtualenv and possibly reducing the time CI takes to run.
Workflows take half the time with the changes in this PR.