simplify threejs imports #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were importing from specific three/src files. Why change? Because:
- we can still tree shake
- we were actually (indeirectly) using bare imports before, too: MathBox (via Threestrap) imports from "three/examples/jsm/controls/OrbitControls", and OrbitControls imports bare "three"
- "three" seems like the more official import pattern; it's what is documented at https://threejs.org/docs/#manual/en/introduction/Installation
See also #49
|
Great work, I'll get all these reviewed and merged this morning. It was really nice to see the bundle size improvements! |
|
As you say, it looks like the failures come from no threestrap 0.5.1 yet. I'm excited to get publishing automated here... Thanks for undoing my unintentionally-destructive work here!! |
|
(Merge away when threestrap's published) |
Now that it's published
|
@sritchie Thanks for the reviews! PR for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the "three" imports as discussed in #49.
Do not merge: Until Threestrap v0.5.1 is published. Oh, the CI tests should fail until then anyway.