Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crawler strategy exception handling and fixes #271

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

NanmiCoder
Copy link
Contributor

@NanmiCoder NanmiCoder commented Nov 17, 2024

Bug Description:

The following code captures exceptions but is missing the variable e. If this exception occurs, the program will lack the variable e and will panic.

except InvalidArgumentException:
if not hasattr(e, 'msg'):
e.msg = sanitize_input_encode(str(e))
raise InvalidArgumentException(f"Failed to crawl {url}: {e.msg}")

Copy link
Collaborator

@ntohidikplay ntohidikplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct.

@unclecode unclecode merged commit 3439f78 into unclecode:main Nov 20, 2024
@unclecode
Copy link
Owner

Thanks for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants