JDK11+ nashorn scripting, SecurityManager update, Gradle 7.6 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK 11+ buildable (nashorn is not built with 8) Gradle and dependency upgrades
# Conflicts: # build.gradle # buildSrc/build.gradle # buildSrc/src/main/groovy/LessCompiler.groovy # buildSrc/src/main/groovy/WikiFileListBuilderTask.groovy # gradle/wrapper/gradle-wrapper.properties
# Conflicts: # build.gradle # buildSrc/build.gradle
fhoeben
reviewed
Aug 9, 2023
| this(ENGINE_MANAGER.getEngineByName(engineName)); | ||
| } | ||
|
|
||
| public SlimExpressionEvaluator(ScriptEngine engine) { |
There was a problem hiding this comment.
Why not keep this constructor and feed it the nashhorn engine?
There was a problem hiding this comment.
I thought to do it this way, so we had the nashorn import and scriptengine initialization only in this file. I can see the compatibility argument to keep the old constructor. Not really a preference for one or the other.
|
@jediwhale what do you think about switching to Java 11 and dropping Java 8 support. Is that an issue for you? |
|
OK with me |
fhoeben
added a commit
to fhoeben/fitnesse
that referenced
this pull request
Oct 29, 2023
# Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference.
This branch runs scripting (slim symbol expressions) with Java 11 and up. It incorporates OpenJDK Nashorn instead of depending on the previously built in nashorn scriptengine.
Also removed the no-longer existed methods from the SecurityManager implementation (but it should be removed entirely imho) and upgraded Gradle and other dependencies.
Note: this branch can no longer be compiled using JDK8.