Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/gov): migrations from 2 to 3 (min proposer deposit) (#298) (#302) #9

Merged
merged 5 commits into from
Aug 3, 2022
Merged

fix(x/gov): migrations from 2 to 3 (min proposer deposit) (#298) (#302) #9

merged 5 commits into from
Aug 3, 2022

Conversation

lydia-pierce
Copy link
Collaborator

  • git checkout -b roman/fix-gov-migrations

  • register migrations

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@p0mvn
fix(x/gov): migrations from 2 to 3 (min proposer deposit) (cosmos#298) (
2cc5b1a 
cosmos#302)

* git checkout -b roman/fix-gov-migrations

* register migrations
p0mvn and others added 3 commits July 30, 2022 17:09
@p0mvn @czarcas7ic
feat!: initial deposit requirement for proposals (backport cosmos#296) (
643737b 
cosmos#297)

* feat!: initial deposit requirement for proposals (backport cosmos#296)

* Update x/gov/legacy/v3/store_test.go

Co-authored-by: Adam Tucker <[email protected]>

* Update x/gov/simulation/genesis.go

Co-authored-by: Adam Tucker <[email protected]>

Co-authored-by: Adam Tucker <[email protected]>
@p0mvn
fix(x/gov): migrations from 2 to 3 (min proposer deposit) (cosmos#298) (
5bcba4f 
cosmos#302)

* git checkout -b roman/fix-gov-migrations

* register migrations
Merge branch 'lydia/minproposaldeposit' of https://github.com/pomifer…
c82c67b 
…/cosmos-sdk into lydia/minproposaldeposit
@lydia-pierce lydia-pierce marked this pull request as ready for review July 30, 2022 22:38
@lydia-pierce
Copy link
Collaborator Author

The two broken tests were also broken in #2 and #4, so they should be fine.

@lydia-pierce lydia-pierce merged commit 4788760 into release/v0.45.x Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:Simulations C:x/gov C:x/params
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lydia-pierce @p0mvn