This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
WIP: Descriptors #340
Closed
WIP: Descriptors #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump, this would be really useful |
This was referenced Feb 20, 2024
@vindard Good news! The package providing the functionality is now live on npm here. We've also migrated all of the caravan and related open source code to a monorepo where ongoing development and maintenance will be happening. This includes the functionality originally introduced in this PR! Checkout the new repo at https://github.com/caravan-bitcoin/caravan and the deployment with descriptor support here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for loading a wallet config from a descriptor as well as the ability to download the descriptors for a loaded wallet config.
This depends on a new beta package that hasn't been released yet: https://github.com/bucko13/caravan-descriptors
This package uses bdk under the hood with special bindings that compiles to wasm.
To confirm that the config and descriptors give us the same wallet, we can compare the address list from each config type.
Here's an address list from the config:
Here's the address list from the descriptor:
Does this PR introduce a breaking change?
Does this PR fix an open issue?