allow $merge entries in cfn Resources:
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavisrudd
changed the title
$merge entries in cnf Resources:$merge entries in cfn Resources:
|
oops. type in the commit message. fixing ... |
The commit also refactors the implementation of `visitResourceNode` and moves custom resource handling to `visitCustomResource`.
tavisrudd
force-pushed
the
allow-$merge-in-cfn-Resources-node
branch
from
2017e1a to
1d1fd1c
Compare
| // This ties in with supporting singleton custom resources that should be shared amongst templates | ||
| return _.map(_.toPairs(outputResources), ([resname, val]) => { | ||
| const isGlobal = _.has(val, '$global'); | ||
| delete val.$global; |
There was a problem hiding this comment.
was answered in slack conversation: this is not intended to appear in the cfn yaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit also refactors the implementation of
visitResourceNodeandmoves custom resource handling to
visitCustomResource.