Skip to content

Commit

Permalink
bump node version to 14x
Browse files Browse the repository at this point in the history
and update the docker base images
  • Loading branch information
tavisrudd committed Sep 29, 2021
1 parent a6b375d commit 63747d4
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
${{ runner.os }}-
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '14.x'
- run: npm ci
- run: npm run coverage
- name: Fix Code Coverage Paths
Expand Down
10 changes: 5 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12-alpine
FROM node:14-alpine

WORKDIR /tmp/iidy

Expand All @@ -8,13 +8,13 @@ COPY . .

RUN apk update && apk add --no-cache binutils git \
&& npm ci . && npm run build \
&& $(npm bin)/pkg --out-path dist -t node8-alpine-x64 package.json \
&& strip /root/.pkg-cache/*/fetched-v8* \
&& $(npm bin)/pkg --out-path dist -t node8-alpine-x64 package.json
&& $(npm bin)/pkg --out-path dist -t node14-alpine-x64 package.json \
&& strip /root/.pkg-cache/*/fetched-* \
&& $(npm bin)/pkg --out-path dist -t node14-alpine-x64 package.json
# We run pkg twice. First to grab the base binary then again after we strip it.
# This strips 8Mb off the total image size.

FROM alpine:3.9
FROM alpine:3.14

RUN apk --no-cache add libstdc++ git

Expand Down
3 changes: 1 addition & 2 deletions Dockerfile.test-npm-build
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:10-alpine
FROM node:14-alpine

WORKDIR /tmp/iidy

Expand All @@ -8,4 +8,3 @@ RUN apk update && apk add --no-cache git \
&& npm ci . && npm run build && ln -s /tmp/iidy/bin/iidy /usr/bin/

ENTRYPOINT ["/usr/bin/iidy"]

2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"build": "tsc -p .",
"watch": "tsc --watch",
"lint": "tslint -p . src/*ts src/**/*ts",
"pkg-binaries": "pkg --out-path dist -t node12-macos,node12-linux package.json",
"pkg-binaries": "pkg --out-path dist -t node14-macos,node14-linux package.json",
"test": "mocha lib/tests/**/*js",
"test-watch": "mocha --watch lib/tests/**/*js",
"ts-test-watch": "mocha --watch src/tests/**/*ts",
Expand All @@ -20,7 +20,7 @@
"repository": "https://github.com/unbounce/iidy",
"license": "MIT",
"engines": {
"node": ">=12.0.0",
"node": ">=14.0.0",
"npm": ">=6.0.0"
},
"dependencies": {
Expand Down

0 comments on commit 63747d4

Please sign in to comment.