Add types for get_client_ip parameters #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@federicobond please kindly change the PR against the CI branch. Thx |
|
Hi @un33k! Like this? |
|
Thank you! |
un33k
added a commit
that referenced
this pull request
Feb 4, 2024
|
It is pushed to pypi at 6.0.4. Thanks again. |
|
@un33k could it be that the package does not contain the py.typed file when installed via pip? This is preventing mypy from recognizing the types. |
|
Might need to adjust |
|
I'll push up the PRs as they arrive. Thx |
|
I'm sorry, I did not understand what you said. |
|
I meant: community enhancement PRs are welcomed whether it'd be for setup.py or anything else. |
un33k
added a commit
that referenced
this pull request
Apr 11, 2024
* Add types for get_client_ip parameters (#110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.