Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin our chromedriver version to 114.x #289

Closed
wants to merge 2 commits into from

Conversation

werebus
Copy link
Member

@werebus werebus commented Jul 20, 2023

Bandaid for #288

It's a race. Hopefully, selenium-webdriver 4.11 comes out before Chrome 116.

spec/spec_helper.rb Outdated Show resolved Hide resolved
@benmelz
Copy link
Member

benmelz commented Jul 20, 2023

python versioning mismatch now? or something it looks like?

@werebus
Copy link
Member Author

werebus commented Jul 20, 2023

python versioning mismatch now? or something it looks like?

Interestingly, comparing that build to a previous one:

  • Downloading the pre-built node failed for... some reason.
  • nvm fell back to downloading source instead
  • The ./configure script for Node.js, which we don't usually run, needs Python and the default Travis VM doesn't actually have it.

I'm about to fix some single quotes (Calm down, codeclimate) so here's hoping it was a transient network problem.

@werebus
Copy link
Member Author

werebus commented Jul 20, 2023

After all that, looks like #290 works fine and seems like a better solution.

@werebus werebus closed this Jul 20, 2023
@werebus werebus deleted the werebus/pin-chromedriver-114 branch July 20, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants