Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure after 8pm #287

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix test failure after 8pm #287

merged 2 commits into from
Jul 27, 2023

Conversation

werebus
Copy link
Member

@werebus werebus commented Jul 20, 2023

My browser is in the EDT time zone. But in UTC it's already tomorrow. So Time.zone.today.day returns a different number than the calendar on the site.

Failing test locally:

it 'highlights today' do
visit roster_assignments_path(roster)
today = Time.zone.today.day
expect(page).to have_selector('td.fc-day-today', text: today)
end

My _browser_ is in the EDT time zone. But in UTC it's already tomorrow.
So `Time.zone.today.day` returns a different number than the calendar on
the site.
@werebus
Copy link
Member Author

werebus commented Jul 20, 2023

Won't be able to see if this works until #288 is fixed.

@werebus werebus merged commit 334b3ba into main Jul 27, 2023
@werebus werebus deleted the werebus/time-zone branch July 27, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants