-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: antd config setter conflict with model plugin #12406
fix: antd config setter conflict with model plugin #12406
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough此次更新主要在 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
if (!cacheAntdConfig.theme) { | ||
cacheAntdConfig.theme = {}; | ||
} | ||
{{/modelPluginCompat}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
antd 的 config provider 中,如果不配置 theme ,会 fallback 到 || {}
,所以这里使用空对象不会影响到什么。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/plugins/src/antd.ts (2 hunks)
- packages/plugins/templates/antd/runtime.ts.tpl (1 hunks)
Additional comments not posted (2)
packages/plugins/templates/antd/runtime.ts.tpl (1)
47-51
: 初始化cacheAntdConfig.theme
以避免后续访问时出现未定义错误,改动合理。packages/plugins/src/antd.ts (1)
313-325
: 添加modelPluginCompat
变量以处理主题更改与模型数据更新之间的潜在冲突,逻辑正确。
close #12394
修复使用
useAntdConfigSetter
方法更改主题时,和 model 插件逻辑发生的冲突。Summary by CodeRabbit
modelPluginCompat
的支持,增强了插件的兼容性。getAntdConfig
函数,确保cacheAntdConfig.theme
在不存在时能被初始化。