Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: received props on qiankun slave update #12337

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Apr 27, 2024

fix #12306

修复 qiankun 子应用更新时漏传了 routes info 对象,这会导致 <MicroAppLink /> 后续收不到这个字段失效。

Summary by CodeRabbit

  • Refactor
    • Enhanced the route management in the MicroApp component for simplified configuration handling.

Copy link

coderabbitai bot commented Apr 27, 2024

Walkthrough

The update to the MicroApp component introduces a centralized storage for route information using a new __globalRoutesInfo object. This change enhances the clarity and efficiency of route handling within the component, addressing issues related to the propagation of route data to child applications.

Changes

File Change Summary
.../libs/qiankun/master/MicroApp.tsx Added __globalRoutesInfo for centralized route management

Assessment against linked issues

Objective Addressed Explanation
Ensure __globalRoutesInfo is available during child app updates (#12306)
Correct URL generation in MicroAppLink when path has placeholders (#12306) No changes made to MicroAppLink or urlFactory to address placeholder issue.

🐇 A Poem by CodeRabbit 🐇

In the land of code, where routes intertwine,
A rabbit hopped in, with a fix so fine.
No more chaos in the web's deep burrow,
For __globalRoutesInfo clears the sorrow.
Hop, skip, and jump, the data's set right,
Now every path is a delightful sight. 🌟


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9d160fc and f30412e.
Files selected for processing (1)
  • packages/plugins/libs/qiankun/master/MicroApp.tsx (3 hunks)
Files not reviewed due to errors (1)
  • packages/plugins/libs/qiankun/master/MicroApp.tsx (no review received)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 6:57pm

@sorrycc sorrycc merged commit d16471a into umijs:master Apr 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【Bug】MicroApp 在更新子应用时缺少 __globalRoutesInfo
2 participants