fix(esbuildHelperChecker): catch js parse error #12285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
WalkthroughThe recent update to the Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Size Change: +69 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+44
to
+74
| export async function getGlobalVars(opts: { | ||
| content: string; | ||
| fileName: string; | ||
| }) { | ||
| const vars: string[] = []; | ||
| ast.program.body.forEach((node) => { | ||
| if (t.isVariableDeclaration(node)) { | ||
| node.declarations.forEach((declaration) => { | ||
| if (t.isVariableDeclarator(declaration)) { | ||
| if (t.isIdentifier(declaration.id)) { | ||
| vars.push(declaration.id.name); | ||
| /** | ||
| * 产物目录可能会有用户自定义的非标准 js 文件，会导致 parse 异常，这里转为 error 提示，不中断程序 | ||
| * eg. git lfs 会生成不符合 js 规范的 js 文件 | ||
| */ | ||
| try { | ||
| const ast = parser.parse(opts.content, { | ||
| sourceType: 'module', | ||
| sourceFilename: 'foo.js', | ||
| plugins: [], | ||
| }); | ||
| ast.program.body.forEach((node) => { | ||
| if (t.isVariableDeclaration(node)) { | ||
| node.declarations.forEach((declaration) => { | ||
| if (t.isVariableDeclarator(declaration)) { | ||
| if (t.isIdentifier(declaration.id)) { | ||
| vars.push(declaration.id.name); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| }); | ||
| } catch (error: any) { | ||
| logger.error( | ||
| `[esbuildHelperChecker] Failed to parse ${opts.fileName}, ${error.message}`, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Refine the hardcoded filename in parser options.
The sourceFilename property in the parser options is currently hardcoded to 'foo.js'. It would be more appropriate to use the actual fileName from the function's parameters to enhance the error context and debugging process.
- sourceFilename: 'foo.js',
+ sourceFilename: opts.fileName,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| export async function getGlobalVars(opts: { | |
| content: string; | |
| fileName: string; | |
| }) { | |
| const vars: string[] = []; | |
| ast.program.body.forEach((node) => { | |
| if (t.isVariableDeclaration(node)) { | |
| node.declarations.forEach((declaration) => { | |
| if (t.isVariableDeclarator(declaration)) { | |
| if (t.isIdentifier(declaration.id)) { | |
| vars.push(declaration.id.name); | |
| /** | |
| * 产物目录可能会有用户自定义的非标准 js 文件，会导致 parse 异常，这里转为 error 提示，不中断程序 | |
| * eg. git lfs 会生成不符合 js 规范的 js 文件 | |
| */ | |
| try { | |
| const ast = parser.parse(opts.content, { | |
| sourceType: 'module', | |
| sourceFilename: 'foo.js', | |
| plugins: [], | |
| }); | |
| ast.program.body.forEach((node) => { | |
| if (t.isVariableDeclaration(node)) { | |
| node.declarations.forEach((declaration) => { | |
| if (t.isVariableDeclarator(declaration)) { | |
| if (t.isIdentifier(declaration.id)) { | |
| vars.push(declaration.id.name); | |
| } | |
| } | |
| } | |
| }); | |
| } | |
| }); | |
| }); | |
| } | |
| }); | |
| } catch (error: any) { | |
| logger.error( | |
| `[esbuildHelperChecker] Failed to parse ${opts.fileName}, ${error.message}`, | |
| ); | |
| } | |
| export async function getGlobalVars(opts: { | |
| content: string; | |
| fileName: string; | |
| }) { | |
| const vars: string[] = []; | |
| /** | |
| * 产物目录可能会有用户自定义的非标准 js 文件，会导致 parse 异常，这里转为 error 提示，不中断程序 | |
| * eg. git lfs 会生成不符合 js 规范的 js 文件 | |
| */ | |
| try { | |
| const ast = parser.parse(opts.content, { | |
| sourceType: 'module', | |
| sourceFilename: opts.fileName, | |
| plugins: [], | |
| }); | |
| ast.program.body.forEach((node) => { | |
| if (t.isVariableDeclaration(node)) { | |
| node.declarations.forEach((declaration) => { | |
| if (t.isVariableDeclarator(declaration)) { | |
| if (t.isIdentifier(declaration.id)) { | |
| vars.push(declaration.id.name); | |
| } | |
| } | |
| }); | |
| } | |
| }); | |
| } catch (error: any) { | |
| logger.error( | |
| `[esbuildHelperChecker] Failed to parse ${opts.fileName}, ${error.message}`, | |
| ); | |
| } |
fz6m
reviewed
Apr 16, 2024
packages/preset-umi/src/features/esbuildHelperChecker/esbuildHelperChecker.ts
Show resolved
Hide resolved
sorrycc
approved these changes
Apr 18, 2024
delete-merged-branch
bot
deleted the
fix/esbuildHelperChecker/catcherror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
产物目录可能会有用户自定义的非标准 js 文件，会导致 parse 异常，这里转为 error 提示，不中断 esbuildHelperChecker 检查
Summary by CodeRabbit