-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mako): add default plugin key when mako is enabled #12264
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
WalkthroughThis update introduces a conditional enhancement to the handling of temporary files within a specific module. The core change revolves around adjusting the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Size Change: +48 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/preset-umi/src/features/tmpFiles/tmpFiles.ts (1 hunks)
Additional comments not posted (1)
packages/preset-umi/src/features/tmpFiles/tmpFiles.ts (1)
449-451
: Consider adding a detailed comment explaining the temporary nature of this solution and any potential impacts or dependencies on theprocess.env.OKAM
environment variable. This will help future maintainers understand the context and reasoning behind this change.
临时解。
ref: umijs/mako#1026
Summary by CodeRabbit