Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: metadata and hydrate root mismatched between csr and ssr #12220
fix: metadata and hydrate root mismatched between csr and ssr #12220
Changes from 10 commits
8edd528
8a970c3
9ff7063
aae6bde
a792b3b
024729a
f3ad7f5
c973bb7
ad5122e
1fee084
90aebf4
20c4472
b1de641
ba7023c
7298ff5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后续删掉 TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lang 不能用 metadata 的配置了,客户端没有,水合会报错
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
线下讨论:Umi 加
htmlLang: string
orlang: string
静态配置,不允许通过 metadataLoader 来改,后续调研下 Next.js 的做法,因为只是 warning 暂时不急There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要考虑
publicPath
的问题,参考packages/preset-umi/src/features/favicons/favicons.ts
,最终得到的 favicons 的 html element 其实是有publicPath
的。There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
线下讨论:改成从 getMarkupArgs 获取模板参数,这样就和非 SSR 逻辑一致了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
属性的添加方式,需要和非 ssr 保持一致,需要规范化,可参考
packages/server/src/server.ts