-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler-webpack): stylus support #11655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +28.6 kB (0%) Total Size: 10.2 MB
ℹ️ View Unchanged
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #11655 +/- ##
==========================================
- Coverage 28.99% 28.99% -0.01%
==========================================
Files 485 485
Lines 14728 14729 +1
Branches 3486 3486
==========================================
Hits 4271 4271
- Misses 9700 9701 +1
Partials 757 757
☔ View full report in Codecov by Sentry. |
fz6m
reviewed
Sep 19, 2023
Co-authored-by: 咲奈Sakina <[email protected]>
fz6m
approved these changes
Sep 19, 2023
sorrycc
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我们内部有很多老的应用使用的是
stylus
, 发现通过 chainWebpack 定制 需要把cssRules
的逻辑重新写一遍、而后续同步 umi 升级需要关注这快的逻辑、所以想着 是不是 bundler-webpack 默认支持下( vite 是默认提供支持的)、 或者暴露addCSSRules
逻辑 不过没有想好咋暴露 更合适