Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint): suppress typescript eslint warning #11625

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Sep 9, 2023

目前 typescript eslint v5 最新版本只标注支持到 < v5.2.0 ,但 ts 发版到 5.2.2 了,所以在 lint 时会发出 ts 版本不匹配的警告( #11567 (comment) ),但这并不影响使用。

所以这里关闭该警告,并且把 ts eslint 版本锁定放开,如果 ts eslint 以后发布新的 v5 版本则无需再次更改,但目测不会再发布新的版本了,以后需要升级到 v6

@vercel
Copy link

vercel bot commented Sep 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2023 5:55am

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f3c9ed0) 29.00% compared to head (8d2c39f) 29.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11625   +/-   ##
=======================================
  Coverage   29.00%   29.00%           
=======================================
  Files         484      484           
  Lines       14716    14716           
  Branches     3480     3480           
=======================================
  Hits         4268     4268           
  Misses       9692     9692           
  Partials      756      756           
Files Changed Coverage Δ
packages/lint/src/config/eslint/index.ts 0.00% <ø> (ø)
packages/lint/src/config/eslint/legacy.ts 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeachScript PeachScript changed the title chore(lint): suppress typescript eslint warning refactor(lint): suppress typescript eslint warning Sep 11, 2023
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sorrycc sorrycc merged commit be6f2d1 into umijs:master Sep 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants