feat: Throw an exception for duplicate runtime plugin keys

umijs · Sep 4, 2023 · f24b3d5 · f24b3d5
1 parent 0b55462
commit f24b3d5
Showing 1 changed file with 38 additions and 21 deletions.
diff --git a/packages/preset-umi/src/features/tmpFiles/tmpFiles.ts b/packages/preset-umi/src/features/tmpFiles/tmpFiles.ts
@@ -430,27 +430,44 @@ if (process.env.NODE_ENV === 'development') {
       key: 'addRuntimePlugin',
       initialValue: [api.appData.appJS?.path].filter(Boolean),
     });
-    const validKeys = [
-      ...new Set(
-        await api.applyPlugins({
-          key: 'addRuntimePluginKey',
-          initialValue: [
-            'patchRoutes',
-            'patchClientRoutes',
-            'modifyContextOpts',
-            'modifyClientRenderOpts',
-            'rootContainer',
-            'innerProvider',
-            'i18nProvider',
-            'accessProvider',
-            'dataflowProvider',
-            'outerProvider',
-            'render',
-            'onRouteChange'
-          ]
-        })
-      )
-    ];
+
+    function checkDuplicatePluginKeys(arr: string[]) {
+      const duplicates: string[] = [];
+      arr.reduce((prev, curr) => {
+        if (prev[curr]) {
+          duplicates.push(curr);
+        } else {
+          prev[curr] = true;
+        }
+        return prev;
+      }, {} as { [k: string]: boolean });
+      if (duplicates.length) {
+        throw new Error(
+          `The plugin key cannot be duplicated. (${duplicates.join(', ')})`,
+        );
+      }
+    }
+
+    const validKeys = await api.applyPlugins({
+      key: 'addRuntimePluginKey',
+      initialValue: [
+        'patchRoutes',
+        'patchClientRoutes',
+        'modifyContextOpts',
+        'modifyClientRenderOpts',
+        'rootContainer',
+        'innerProvider',
+        'i18nProvider',
+        'accessProvider',
+        'dataflowProvider',
+        'outerProvider',
+        'render',
+        'onRouteChange',
+      ],
+    });
+
+    checkDuplicatePluginKeys(validKeys);
+
     const appPluginRegExp = /(\/|\\)app.(ts|tsx|jsx|js)$/;
     api.writeTmpFile({
       noPluginDir: true,