fix: use jsx/runtime only for react 17 and above (#12258)

umijs · Apr 3, 2024 · a365e90 · a365e90
1 parent ac85e52
commit a365e90
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/preset-umi/src/commands/build.ts b/packages/preset-umi/src/commands/build.ts
@@ -99,7 +99,10 @@ umi build --clean
       });
       const shouldUseAutomaticRuntime =
         api.appData.react?.version &&
-        semver.gte(api.appData.react.version, '16.14.0');
+        // why not 16.14.0 ?
+        // it will break the config of externals, when externals
+        // does not handle the react/runtime
+        semver.gte(api.appData.react.version, '17.0.0');
       const opts = {
         react: {
           runtime: shouldUseAutomaticRuntime ? 'automatic' : 'classic',

diff --git a/packages/preset-umi/src/commands/dev/dev.ts b/packages/preset-umi/src/commands/dev/dev.ts
@@ -350,7 +350,7 @@ PORT=8888 umi dev
 
       const shouldUseAutomaticRuntime =
         api.appData.react?.version &&
-        semver.gte(api.appData.react.version, '16.14.0');
+        semver.gte(api.appData.react.version, '17.0.0');
       const opts: any = {
         react: {
           runtime: shouldUseAutomaticRuntime ? 'automatic' : 'classic',