fix: error message #1580
Merged
fix: error message #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
Jul 19, 2021
src/error.ts
Outdated
| } | ||
| } | ||
|
|
||
| export const isQiankunError = (error: any): error is QiankunError => { |
docs/api/README.zh.md
Outdated
| @@ -78,6 +78,8 @@ toc: menu | |||
| type Lifecycle = (app: RegistrableApp) => Promise<any>; | |||
| ``` | |||
|
|
|||
| - beforeImport - `Lifecycle | Array<Lifecycle>` - 可选 | |||
There was a problem hiding this comment.
beforeImport 应该是没必要的，调用了 loadMicroApp 可以等价于触发了 beforeImport，这中间误差在 ms 以内
ttys026
force-pushed
the
feat/import-lifeCycles
branch
from
7f21fd3
to
ce8b5a1
Compare
kuitos
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
beforeImportandafterImport, which indicate the start and end ofimportEntry stage