🎨 optimize current proxy setting logic #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howel52
reviewed
Jun 7, 2021
| @@ -123,7 +123,11 @@ test('hasOwnProperty should works well', () => { | |||
| test('descriptor of non-configurable and non-enumerable property existed in raw window should be the same after modified in sandbox', () => { | |||
| Object.defineProperty(window, 'nonConfigurableProp', { configurable: false, writable: true }); | |||
| // eslint-disable-next-line getter-return | |||
| Object.defineProperty(window, 'nonConfigurablePropWithAccessor', { configurable: false, get() {}, set() {} }); | |||
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
Keep the current sandbox getter as accurate as possible, might could resolve some issue about sandbox getting incorrect in multiple Instance scenario.
This change need to be test if it has a performance impact.
Probably it could fix #1266