fix: ignored module should be compiled to empty es module #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormslowly
approved these changes
Mar 12, 2024
sorrycc
approved these changes
Mar 12, 2024
xusd320
added a commit
that referenced
this pull request
Mar 13, 2024
* fix: ignored module should be compiled to empty es module * test: update e2e resolve.ignored * test: update e2e resolve.ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：
ignored 替换为 "" 空字符串，swc 会将其识别为 cjs module，导致产物模块导出内容多一个 default 属性，内容为 { default: {} }
解法：
ignored 替换为 "export {};", 显示标记为 es module，产物模块导出内容为 {} 空对象，和 webpack 对齐。