New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic import and require within call expr #898

Merged

PeachScript merged 2 commits into master from hotfix/context-module-within-call-expr

Feb 28, 2024

Member

PeachScript commented Jan 30, 2024

修复在 call_expr 中的动态 require/import 未被正常转换的问题，原因是 visitor 没有继续 visit call_expr 的子节点

增加了两个用例：

import(...).then(...)，测试 call_expr -> member_expr -> call_expr 的场景
import(...${require(...)}...)，测试 call_expr -> call_expr 的场景

PeachScript added 2 commits

January 30, 2024 14:04


          fix: cannot resolve dynamic import with then

b06e959


          test: add case for nested dynamic require

5d98d30

stormslowly approved these changes

View reviewed changes

Member

stormslowly left a comment

+1

PeachScript merged commit f08ea42 into master

8 checks passed

delete-merged-branch bot deleted the hotfix/context-module-within-call-expr branch

February 28, 2024 10:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet