Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic import css #756

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: dynamic import css #756

merged 2 commits into from
Dec 7, 2023

Conversation

jiesia
Copy link
Contributor

@jiesia jiesia commented Dec 6, 2023

修复动态导入 css 不能正常工作的问题。

Close #754

sorrycc
sorrycc requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再单独补个只有 import('./xxx.css') 的用例吧，expect 下结果是否符合预期。

crates/mako/src/transformers/transform_dep_replacer.rs Outdated Show resolved Hide resolved
crates/mako/src/transformers/transform_dep_replacer.rs Outdated Show resolved Hide resolved
@sorrycc sorrycc changed the title fix: fix dynamic import css fix: dynamic import css Dec 6, 2023
@jiesia
Copy link
Contributor Author

jiesia commented Dec 6, 2023

再单独补个只有 import('./xxx.css') 的用例吧，expect 下结果是否符合预期。

done

@sorrycc sorrycc merged commit 769c085 into master Dec 7, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/dynamic-import-css branch December 7, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormslowly stormslowly stormslowly left review comments

@sorrycc sorrycc sorrycc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import('./foo.css') 不能正常工作
3 participants
@jiesia @sorrycc @stormslowly