Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🎨 rayon is not friendly to js users #1601

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Sep 19, 2024

when unexpected panic happens, node process aborts , the log does not show it's a error of mako

thread 'rayon thread 5' panicked at crates/svgr-rs/src/hast_to_swc_ast/decode_xml.rs:60:21:
byte index 11 is not a char boundary; it is inside '文' (bytes 10..13) of `¥a&中文`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Rayon: detected unexpected panic; aborting
Abort trap: 6

Change rayon thread x -> Mako thread x

Summary by CodeRabbit

  • 新功能
    • 更新线程池和Tokio运行时的线程命名,提升了品牌识别度。
  • 错误修复
    • 改进了线程池和Tokio运行时创建失败时的错误提示信息。

@stormslowly stormslowly changed the title refactor: 🎨 rayon is not friendly to js users chore: 🎨 rayon is not friendly to js users Sep 19, 2024
@xusd320
Copy link
Contributor

xusd320 commented Sep 19, 2024

tokio worker 也顺便改掉好了
image

Copy link
Contributor

coderabbitai bot commented Sep 19, 2024

Walkthrough

本次更改涉及对 mako crate 中线程池和 Tokio 运行时功能的错误消息和线程命名约定的修改。线程名称分别从“rayon thread”和“tokio-worker”更改为“Mako thread”和“Mako-tokio-worker”,同时相应的错误消息也进行了更新。这些更改旨在提高错误消息的清晰度和品牌识别,但不影响代码的逻辑或控制流。

Changes

文件 更改摘要
crates/mako/src/utils/thread_pool.rs - 线程名称格式从 format!("rayon thread {}", i) 更改为 format!("Mako thread {}", i)
- 错误消息从 .expect("failed to create rayon thread pool.") 更改为 .expect("Mako failed to create thread pool.")
crates/mako/src/utils/tokio_runtime.rs - 线程名称从 "tokio-worker" 更改为 "Mako-tokio-worker"
- 错误消息从 .expect("failed to create tokio runtime.") 更改为 .expect("Mako: failed to create tokio runtime.")

Possibly related PRs

Poem

在兔子窝里,线程跳跃,
Mako 的名字,响亮而骄傲。
错误消息清晰,调试无忧,
一起欢庆,代码更美好!
🐰✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5122b28 and 242bfcf.

Files selected for processing (1)
  • crates/mako/src/utils/tokio_runtime.rs (1 hunks)
Files skipped from review due to trivial changes (1)
  • crates/mako/src/utils/tokio_runtime.rs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.12%. Comparing base (8265a42) to head (242bfcf).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   62.11%   62.12%   +0.01%     
==========================================
  Files         129      129              
  Lines       15561    15561              
==========================================
+ Hits         9666     9668       +2     
+ Misses       5895     5893       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stormslowly stormslowly merged commit 457f3ed into master Sep 19, 2024
21 checks passed
@stormslowly stormslowly deleted the chore/rename_thread_name branch September 19, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants