Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunk file name should be url-friendly #1434

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

PeachScript
Copy link
Member

@PeachScript PeachScript commented Jul 22, 2024

修复配置 moduleIdStrategy: 'named' 时生成的 chunk 文件名可能包含 @ 的问题,文件名被 encode 可能会导致 CDN 资源访问失败

Summary by CodeRabbit

  • 新特性
    • 改进了组件字符串表示的处理,使用更清晰的一致性字符串。
    • 扩展了对普通组件的逻辑,增强了段名称的标准化处理。

Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

Walkthrough

此次更改优化了Chunk实现中组件的字符串表示方式。特别是,Component::ParentDirComponent::Prefix的处理被更新为返回"_pd_""_ps_",而非之前的"@"。此外,Component::Normal的逻辑得到了扩展,以将'.''?''@'替换为下划线'_',提升了段名称的清晰度和一致性。

Changes

文件路径 更改摘要
crates/mako/src/generate/chunk.rs 修改了组件字符串表示,优化了ParentDirPrefixNormal的处理逻辑。

Sequence Diagram(s)

(此部分省略,因为变更过于简单,没有生成相应的序列图)

Poem

在草地上我跳跃欢腾,
看到变化心中激动,
"_pd_""_ps_"闪亮,
清晰字符串如星光。
小兔子庆祝新进展,
代码更美,真愉快! ✨🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f20b78 and 9c05d7d.

Files selected for processing (1)
  • crates/mako/src/generate/chunk.rs (1 hunks)
Additional comments not posted (3)
crates/mako/src/generate/chunk.rs (3)

77-77: 更改 Component::ParentDir 的处理方式

Component::ParentDir 的处理从 @ 更改为 _pd_,使其更符合 URL 友好标准。


78-78: 更改 Component::Prefix 的处理方式

Component::Prefix 的处理从 @ 更改为 _ps_,使其更符合 URL 友好标准。


81-82: 优化 Component::Normal 的处理逻辑

Component::Normal 中的 '.', '?', '@' 替换为下划线 '_',以提高段名称的清晰度和一致性。

Comment on lines +77 to +78
Component::ParentDir => "_pd_".to_string(),
Component::Prefix(_) => "_ps_".to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd 能理解是 parent dir,ps 是啥?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像是起始路径,start,cc @stormslowly

@sorrycc sorrycc merged commit d866363 into master Jul 23, 2024
8 checks passed
@PeachScript PeachScript deleted the hotfix/chunk-file-url-friendly branch August 9, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants