-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 🎨 idiomatic and concise SWC ast generate #1372
Conversation
Walkthrough本次修改主要涉及 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- crates/mako/src/visitors/dynamic_import.rs (2 hunks)
Additional comments not posted (3)
crates/mako/src/visitors/dynamic_import.rs (3)
134-138
: 初始化ArrayLit
并转换为表达式的代码看起来不错代码正确地初始化了
ArrayLit
并将其转换为表达式。
141-148
: 使用member_expr!
宏构建lazy_require_call
的代码看起来不错宏的使用是正确的,生成的表达式也是预期的。
154-155
: 在load_promise
上调用then
的代码看起来不错方法调用是正确的,参数传递也是预期的。
Need merge master to fixed the ci. |
.
Summary by CodeRabbit
load_promise
、lazy_require_call
和dr_call
的构建方式,使其更直接高效。load_promise
的then
调用逻辑。