-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update mako bundler for new mako version #1229
Conversation
Walkthrough总体变更概述: Changes
Poem
Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
packages/bundler-mako/index.js
Outdated
...opts.config.hooks, | ||
}, | ||
plugins: opts.config.plugins || [], | ||
forkTSChecker: makoConfig.forkTSChecker, | ||
watch: false, | ||
watch: opts.config.watch || false, | ||
hmr: opts.config.hmr || false, | ||
devServer: opts.config.devServer || false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这几个都用 opts.xxx 吧,比如 opts.plugins。因为 umi 和 dumi 场景下,这些都不会出现在用户配置里,而是出现在框架层。
Summary by CodeRabbit
bundler-mako
包中index.js
文件中build
和dev
函数中处理插件和配置选项的方式。