Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mako bundler for new mako version #1229

Merged
merged 3 commits into from
May 31, 2024

Conversation

Jinbao1001
Copy link
Member

@Jinbao1001 Jinbao1001 commented May 31, 2024

Summary by CodeRabbit

  • 新功能
    • 调整了bundler-mako包中index.js文件中builddev函数中处理插件和配置选项的方式。

Copy link
Contributor

coderabbitai bot commented May 31, 2024

Walkthrough

总体变更概述:bundler-mako 包中的 index.js 文件经历了一系列调整,包括在 build 函数中将 hooks 对象替换为 plugins 数组,并根据 opts.config 添加了 watchhmrdevServer 属性。同时,在 dev 函数中修改了 plugins 属性以包含默认插件并调整结构。

Changes

文件 变更概述
docs/config.md 更改了 watch 配置的类型定义,现在包括了 false 选项。
packages/bundler-mako/index.js
- exports.build 函数: 移除了 hooks,新增了 pluginswatchhmrdevServer 属性。
- exports.dev 函数: 修改了 plugins 属性,添加了默认插件,并调整了结构。

Poem

兔子编码忙修改,

bundler-mako 新风采。

插件配置变全新,

代码如诗般流转。

欢畅升级乐无穷。🐰


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines 47 to 50
...opts.config.hooks,
},
plugins: opts.config.plugins || [],
forkTSChecker: makoConfig.forkTSChecker,
watch: false,
watch: opts.config.watch || false,
hmr: opts.config.hmr || false,
devServer: opts.config.devServer || false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个都用 opts.xxx 吧,比如 opts.plugins。因为 umi 和 dumi 场景下,这些都不会出现在用户配置里,而是出现在框架层。

@sorrycc sorrycc merged commit 32ee59e into master May 31, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bundler/update_hooks_to_plugins branch May 31, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants