-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transform): support useDefineForClassFields Config #1181
Conversation
Walkthrough整体变更包括对配置文件和代码的更新,引入了新的结构体和方法。JavaScript项目中添加了测试工具和配置文件,以及类和方法的示例。Bundler工具的配置和构建功能也有所更新。 Changes
Poem
Tip Early Access Features
Note Pull Request Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1、什么场景下一定需要 useDefineForClassFields?
2、如果这种方式更优,为啥不默认开启?
3、配置方式待讨论
02d3ca8
to
0c5dfbe
Compare
close #1172
and part of #1178
why and ref : #1172 (comment)
implementation reference: https://github.com/swc-project/swc/blob/main/crates/swc/src/config/mod.rs#L293-L297
Summary by CodeRabbit